Skip to content

Fix failing pipeline, and validate by adding a dotless j character.#74

Merged
pelson merged 4 commits intoipython:masterfrom
pelson:feature/oe_ae_ligatures
Apr 27, 2026
Merged

Fix failing pipeline, and validate by adding a dotless j character.#74
pelson merged 4 commits intoipython:masterfrom
pelson:feature/oe_ae_ligatures

Conversation

@pelson
Copy link
Copy Markdown
Member

@pelson pelson commented Apr 26, 2026

I also make it possible to re-run later stages without needing to re-run earlier ones.

pelson added 4 commits April 26, 2026 08:44
… are added locally, they aren't in the old reference OTF so they get committed with raw FontForge bytecode (containing callsubr

tokens). On the next CI rebuild those glyphs are in the reference, so the freeze loop inlines their subr calls — producing different bytes from what's committed.

The fix adds a second pass after the freeze loop that desubroutinizes all charstrings using the new font's own subr table. New glyphs are normalised on the same local build they're added, so what gets
committed is already stable. CI sees inlined charstrings in the reference, _inline_subrs is a no-op, and the bytes are identical.
… re-run earlier ones. Before this the latest stage you could start with was stage 4.
@pelson pelson requested review from Carreau and rgbkrk April 26, 2026 06:55
@pelson
Copy link
Copy Markdown
Member Author

pelson commented Apr 27, 2026

Going to ship it to fix the pipeline, and let's me make another PR 😉

@pelson pelson merged commit c9d2af8 into ipython:master Apr 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant